Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • Tests may need to be reran as they're at times not deterministic

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox and @DeleMike: The commits that are in this PR now have us in a really great place as far as switching Scribe-i18n over to a submodule rather than a subtree. @catreedle will work on fixing the hard coded strings and keys that have changed since the last update of Scribe-i18n within the project, and then it'd be great if we could do a through review seeing as how this will update many of the texts across the application 😊

Great work so far, @catreedle!

note: Updated the PR description to reflect that this PR will close #527 and #515. We need to bring in the latest version of Scribe-i18n, and then this will finalize both once we fix any keys that are now different and replace some hard coded strings with keys. Let us know if you need support here, @catreedle!

note: Closed #526 in favor of this PR :)

Hi @andrewtavis , I missed the session yesterday to learn how to use the scribe-org/Scribe-i18n Git submodulein the Android app. Can you point me to a resource to see how to see this new update in action in the Android app?

Hi @DeleMike 👋 You can check the docs for Scribe-i18n - the readme - that explains it all. @catreedle will load in the submodule and then we'll be able to edit and load in new versions 😊

Hi @DeleMike 👋 You can check the docs for Scribe-i18n - the readme - that explains it all. @catreedle will load in the submodule and then we'll be able to edit and load in new versions 😊

Thank you @andrewtavis , I will go through it. Thank you!

Let us know when this is ready, @catreedle :) And feel free to start on bringing Scribe-i18n into Scribe-iOS when you're done here :)

Let us know when this is ready, @catreedle :) And feel free to start on bringing Scribe-i18n into Scribe-iOS when you're done here :)

Hi @andrewtavis

question: what to do when some strings are missing for Android but they are already available in i18n, for example "i18n._global.privacy_policy": "Privacy Policy". Because they don't start with "i18n.app" they got filtered out by the convert_jsons_to_strings script?

Great question, @catreedle :) We should update the script to also convert the i18n._global* keys as well. Do you want to do that in Scribe-i18n? And can you look into the iOS conversion to make sure that the xcstrings file is also only getting the i18n.app and i18n._global keys? Maybe it already is, but we should check :)

I'll quickly merge in the changes to Scribe-i18n and then you can bring them over to this PR :)

Great question, @catreedle :) We should update the script to also convert the i18n._global* keys as well. Do you want to do that in Scribe-i18n? And can you look into the iOS conversion to make sure that the xcstrings file is also only getting the i18n.app and i18n._global keys? Maybe it already is, but we should check :)

sure!

I'll quickly merge in the changes to Scribe-i18n and then you can bring them over to this PR :)

made the PR here :)
scribe-org/Scribe-i18n#101

Scribe-i18n has been updated, @catreedle :) Note that I needed to do another commit after I merged your PR as the scripts needed to factor for i18n._global, not i18n.global (we do _global so it's alphabetically before). Let us know when this is ready to be finalized!

Scribe-i18n has been updated, @catreedle :) Note that I needed to do another commit after I merged your PR as the scripts needed to factor for i18n._global, not i18n.global (we do _global so it's alphabetically before). Let us know when this is ready to be finalized!

thank you! :) sorry for the oversight

No need to apologize, @catreedle! 💙🩵

Checking in, @catreedle, are we ready for a review here?